deprecate Variable.value #5052
Open
deprecate Variable.value #5052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgarciae
force-pushed
the
hijax-variable
branch
from
1522229 to
03240fb
Compare
cgarciae
force-pushed
the
deprecate-value-2
branch
from
0551fd4 to
f7f0d27
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
cgarciae
force-pushed
the
hijax-variable
branch
6 times, most recently
from
803cd5d to
2e96cee
Compare
cgarciae
force-pushed
the
deprecate-value-2
branch
2 times, most recently
from
0d0ecb0 to
b9f2302
Compare
cgarciae
force-pushed
the
deprecate-value-2
branch
from
b9f2302 to
cce5921
Compare
IvyZX
approved these changes
Nov 11, 2025
flax/configurations.py
Outdated
| ) | ||
|
|
||
|
|
||
| def str_flag(name: str, *, default: str, help: str) -> FlagHolder[str]: |
Collaborator
There was a problem hiding this comment.
Is this part of the PR? I didn't see any flags using it
Collaborator
Author
There was a problem hiding this comment.
Yeah it was outdated. Updated the branch.
cgarciae
force-pushed
the
deprecate-value-2
branch
3 times, most recently
from
880d881 to
12bfb60
Compare
cgarciae
force-pushed
the
deprecate-value-2
branch
8 times, most recently
from
73bf11e to
dbef8bf
Compare
cgarciae
force-pushed
the
deprecate-value-2
branch
from
dbef8bf to
914b541
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?